Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type definitions for moduleResolution nodenext #827

Merged

Commits on Feb 22, 2023

  1. Fix type definitions for moduleResolution nodenext

    When importing this library in a project using moduleResolution
    nodenext, the types would give errors because the import paths were
    missing the file extension which is required for moduleResolution
    nodenext. Therefore we have to add .js to all imports of local files.
    
    See developit/microbundle#1019 (comment)
    and the issues that comment links to for some more detailed explanation
    of this.
    
    I also changed moduleResolution to nodenext in the tsconfig because when
    it's set to node, typescript won't give errors for missing file
    extensions which means they are easy to forget. With it set to nodenext,
    you will get an error if an import is missing the file extension. As far
    as I can see, changing this doesn't change the build output.
    
    Depends on donmccurdy/property-graph#70 and
    donmccurdy/KTX-Parse#55
    
    Fixes donmccurdy#824
    trygveaa committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    57e9584 View commit details
    Browse the repository at this point in the history