Fix data race when calling GetISO3166
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgepsarakis
commented
Oct 4, 2023
georgepsarakis
commented
- Use parallelization in test cases in order to reproduce the problem and also detect such issues in the future.
- Enable race detector when running unit tests in Github Actions.
- Fix the data race by adding a package-level initialization function that populates the ISO3166 configurations on package initialization only.
- Enable race detector when running unit tests in Github Actions.
The data race was triggered when multiple goroutines tried to access and modify the global variable used for caching ISO3166 per-country configurations.
|
@georgepsarakis Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.