Skip to content

Commit

Permalink
build: only check --engine-strict for production deps (googleapis#406)
Browse files Browse the repository at this point in the history
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/220288a4-7076-443b-9721-9f71deddc661/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5451633
  • Loading branch information
yoshi-automation authored Oct 16, 2020
1 parent 18d6522 commit c13b930
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: node --version
- run: npm install --engine-strict
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
# dependencies that don't match our engines field:
- run: npm install --production --engine-strict
- run: npm install
- run: npm test
- name: coverage
uses: codecov/codecov-action@v1
Expand Down
4 changes: 2 additions & 2 deletions synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-asset.git",
"sha": "d2b27fc846b873e02ba4121ff8a1ed0156c2d679"
"sha": "18d6522d9b0b8362700ce1171417fb23e2c704bc"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9"
"sha": "5451633881133e5573cc271a18e73b18caca8b1b"
}
}
],
Expand Down

0 comments on commit c13b930

Please sign in to comment.