Security Patch #527
Merged
Security Patch #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `session.clear()` to clean the session specific to each login session - Clear all cookie with the `signout` request and also clear again (just in case) in the frontend code.
|
@NOXCIS Hi, when you're free, do you mind testing this branch and see if it solved the issue where you can still do API call even after signed out? I've tested on my side and now you can't. Thanks in advance ;) |
DaanSelen
reviewed
Nov 25, 2024
DaanSelen
approved these changes
Nov 25, 2024
DaanSelen
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session.clear()to clean the session specific to each login sessionsignoutrequest and also clear again (just in case) in the frontend code.