Firefox compatibility patch

domluther · Mar 30, 2021 · 09830d5 · 09830d5
1 parent 0edfe26
commit 09830d5
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/manifest.json b/manifest.json
@@ -14,11 +14,14 @@
         "48": "assets/thumbnail.png",
         "128": "assets/thumbnail.png"
       },
-      "background": {
-        "scripts": ["scripts/background.js"],
-        "persistent": false
-      },
-    "permissions": [
+    "background": {
+      "scripts": ["scripts/background.js"],
+      "persistent": false
+    },
+        "permissions": [
+        "https://github.com/*",
+        "https://api.github.com/*",
+        "https://leetcode.com/*",
         "tabs",
         "activeTab",
         "unlimitedStorage",

diff --git a/popup.html b/popup.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html>
   <head>
+    <meta charset="UTF-8">
     <link rel="stylesheet" href="css/popup.css" />
     <script
       src="https://code.jquery.com/jquery-3.3.1.min.js"

diff --git a/popup.js b/popup.js
@@ -12,11 +12,11 @@ $('#authenticate').on('click', () => {
 /* Get URL for welcome page */
 $('#welcome_URL').attr(
   'href',
-  `chrome-extension://${chrome.runtime.id}/welcome.html`,
+  chrome.runtime.getURL('welcome.html')
 );
 $('#hook_URL').attr(
   'href',
-  `chrome-extension://${chrome.runtime.id}/welcome.html`,
+  chrome.runtime.getURL('welcome.html')
 );
 
 chrome.storage.local.get('leethub_token', (data) => {

diff --git a/scripts/background.js b/scripts/background.js
@@ -27,8 +27,8 @@ function handleMessage(request) {
     });
 
     /* Go to onboarding for UX */
-    const urlOnboarding = `chrome-extension://${chrome.runtime.id}/welcome.html`;
-    chrome.tabs.create({ url: urlOnboarding, selected: true }); // creates new tab
+    const urlOnboarding = chrome.runtime.getURL('welcome.html');
+    chrome.tabs.create({ url: urlOnboarding, active: true }); // creates new tab
   } else if (
     request &&
     request.closeWebPage === true &&

diff --git a/scripts/oauth2.js b/scripts/oauth2.js
@@ -30,7 +30,7 @@ const oAuth2 = {
     chrome.storage.local.set({ pipe_leethub: true }, () => {
       // opening pipe temporarily
 
-      chrome.tabs.create({ url, selected: true }, function () {
+      chrome.tabs.create({ url, active: true }, function () {
         window.close();
         chrome.tabs.getCurrent(function (tab) {
           chrome.tabs.remove(tab.id, function () {});