Fixes and features #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the wholesale blocking of lease acquisition by shifting and adding mutex locking
forgot to append auths generated from CIB into new IB resource
pushed images need to have the target registry prepended
- does not try to bind to default exchange (this is not allowed) - performs a full reconnect after xPassive() failures - updates amqp091-go lib dep
- passes annotations in full from CIB to IB - sends annotations along in status update message
it doesn't come from "imagebuilder.dominodatalab.com/build-id" annotation
matches format expected by our system. consumers of the helm chart are still capable of modifying it for their needs
- sets a "static" input since only 1 is required - converts transforms/sinks from str to map since no templating is required
passing the message on its own results in a byte-representation of the body which is noisy and not very helpful
required to ensure only 1 consumer can process serialized event stream
forgot to initialize shutdown channel. also adds additional debug logging useful in diagnosing this issue
consumed and propagated by ContainerImageBuild controller into ImageBuild
creates better logs by improving messages and clearing out some noise places StatusMessengerComponent into its own controller so it can publish messages in real-time instead of waiting until the BuildDispatcherComponent has completed its work. this also consumes and applies AMQP overrides. this new controller only listens to "update" events.
uses a "patch" json strategy instead of updates so that the 2 controllers watching ImageBuild resources won't overwrite each other's changes
this delay slows down scale-up times and pods seems to operate just fine without it. we can add it back as a configurable value with a default if/when problems arise.
- includes no cache, disable export, and import cache from fields - adds missing build arg processing in buildkit
steved
approved these changes
May 5, 2022
also fixes helm job issue references old job name for output
since we're trying to mirror a different remote tag version
- ensures deps are up-to-date - ensures all generated files are up-to-date - exports GOPATH required by client-gen bin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
logKeypropagationConversionShimComponentChannelManager