Improves Java SDK generation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the security fields generates a client that is incapable of using bearer tokens. derp
i believe the older version of kind has issues with k8s v1.24
and pushes JARs for branches
hopefully
so we can evaluate the branch name within the generate script
and updates gh action plugin versions
notating changes to both images
steved
approved these changes
Jul 27, 2022
Comment on lines
+176
to
+202
| // name = strings.ReplaceAll(name, "github.com/dominodatalab/hephaestus/pkg/api/hephaestus/v1", "") | ||
| // name = strings.ReplaceAll(name, "k8s.io/apimachinery/pkg/apis/meta/", "") | ||
| // | ||
| // return name | ||
| } | ||
|
|
||
| // func walkOperation(op *spec3.Operation) { | ||
| // if reqBody := op.RequestBody; reqBody != nil { | ||
| // for _, mediaType := range reqBody.Content { | ||
| // if schema := mediaType.Schema; schema != nil { | ||
| // ref := schema.Ref | ||
| // | ||
| // switch { | ||
| // case strings. | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| // | ||
| // for _, response := range op.Responses.StatusCodeResponses { | ||
| // for _, mediaType := range response.Content { | ||
| // if schema := mediaType.Schema; schema != nil { | ||
| // schema.Ref = refFunc(schema.Ref.String()) | ||
| // } | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Is this going to be used for something in a follow-up?
There was a problem hiding this comment.
Yeah, the /openapi/v3 endpoint is much more user-friendly than the v2 one because it returns targeted resources (i.e. /openapi/v3/apis/hephaestus.dominodatalab.com/v1) instead of EVERYTHING. It's useful but not critical for this work so I'm going to do that work slowly and deliberately as a separate PR when I have time. These are just my notes for that future work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list/getoperations to fail