buildkit updates #231
Merged
buildkit updates #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-retornam
force-pushed
the
retornam/buildkit
branch
4 times, most recently
from
52d5791 to
435537f
Compare
Add the version flag to the command flags and also update Dockerfile to accept the version build-arg using the git describe --tags --always so we can populate the version with either the last git tag or the last git tag with the current SHA. Also updates the Makefile and the Github action script
ddl-retornam
force-pushed
the
retornam/buildkit
branch
from
435537f to
ef5c221
Compare
The workqueue.RateLimitingInterface is deprecated and causes golangci to fail updating to use TypedRateLimitingInterface
Add the built binary to the gitignore list
Secretions
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.