add a deadline to cloud client registration #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steved
force-pushed
the
steved/increase-deadline
branch
from
81b3741 to
ab2f5f0
Compare
steved
changed the title
In AWS, it can take longer than the default to register a client because of IMDS. By setting a deadline, we override the default timeout. Adds debug logging to the AWS client.
steved
force-pushed
the
steved/increase-deadline
branch
from
b1ca64d to
782817e
Compare
steved
force-pushed
the
steved/increase-deadline
branch
from
782817e to
d2482f0
Compare
steved
force-pushed
the
steved/increase-deadline
branch
from
d2482f0 to
98e463f
Compare
fraenkel
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AWS, it can take longer than the default to register a client
because of IMDS. By setting a deadline, we override the default
timeout. Adds debug logging to the AWS client.
Having a built-in env var for this is still pending: aws/aws-sdk-go#3495.