fixed #58 #59
Merged
fixed #58 #59
+228
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fun bug. Thanks @kderholtvisma for the report.
So in rust the compiler checks that a
matchcovers all it's permutations automatically so I don't have to make sure that when I expect to return a number between 0-255 that I miss one. When I ported this over to node I mistyped two conditions which resulted in two numbers not being covered in the node implementation. One of those numbers happened to be the number representation foryellow.I have now added a test to node to make sure I cover all 256 permutations (how I found the other gap) and added tests for rust to compare the output of both rust and node against a fixture for all allowed colors in the gradients.
This last test suit led me to discover that I don't support
yellowin the rust gradient implementation andgrayandgreyin the node one. So both packages will be bumped.🎉