Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modulo on hours in reports #208

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Remove modulo on hours in reports #208

merged 1 commit into from
Jan 21, 2022

Conversation

gmalette
Copy link
Contributor

timetrace doesn't report days, and even if it did, the modulo should be 24, not 60. This almost caused me a heart attack! 😆

@dominikbraun
Copy link
Owner

Thanks for noticing and fixing this! 😄

@dominikbraun dominikbraun merged commit ae0b42e into dominikbraun:main Jan 21, 2022
@gmalette gmalette deleted the gm/remove-modulo-hours branch January 21, 2022 14:34
@gmalette
Copy link
Contributor Author

Thanks! Can you make a release with it please?

@dominikbraun
Copy link
Owner

So this change is contained in release 0.14.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmalette @dominikbraun