Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#145 handle nil pointer dereference for tracked record #150

Merged
merged 2 commits into from
Jul 5, 2021
Merged

#145 handle nil pointer dereference for tracked record #150

merged 2 commits into from
Jul 5, 2021

Conversation

alksmt
Copy link
Contributor

@alksmt alksmt commented Jun 30, 2021

PR for #145

Changes:

  • Fixing issue with nil pointer dereference during collides check against tracked record
  • Simplified collides check conditions (here's a good reference for it: Date ranges overlap check)
  • Added missing test cases for complete records and new ones for records that are being tracked

alksmt added 2 commits June 30, 2021 13:52
aligator
aligator approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@aligator aligator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikbraun dominikbraun linked an issue Jul 4, 2021 that may be closed by this pull request
timetrace create record panics because of nil pointer dereference #145
Closed
dominikbraun
dominikbraun approved these changes Jul 5, 2021
View reviewed changes
Copy link
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun dominikbraun merged commit 7f2ae91 into dominikbraun:main Jul 5, 2021
@dominikbraun
Copy link
Owner

This PR is included in timetrace v0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aligator aligator aligator approved these changes

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timetrace create record panics because of nil pointer dereference
3 participants
@alksmt @dominikbraun @aligator