timetrace delete commands: Default to no when asking for confirmation #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligator
approved these changes
Jun 29, 2021
| } | ||
| } | ||
| return true | ||
| fmt.Fprint(os.Stderr, "Please confirm [y/N]: ") |
There was a problem hiding this comment.
Actually your code looks much cleaner. But I am not sure if @dominikbraun intends to remove the for loop.
I think the for loop is not necessary. So for me it looks ok :-)
There was a problem hiding this comment.
You can throw it out if you want to.
dominikbraun
approved these changes
Jun 29, 2021
| } | ||
| } | ||
| return true | ||
| fmt.Fprint(os.Stderr, "Please confirm [y/N]: ") |
There was a problem hiding this comment.
You can throw it out if you want to.
|
Thanks for solving this, @jwnpoh! Your change will be included in the next release. |
Merged
|
Thrilled to have my first merged PR! Thanks for the opportunity! |
Merged
|
This PR is included in timetrace v0.11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #110.
askForConfirmation()now defaults to no unless the input is specifically "y" or "Y".askForConfirmation()todeleteProjectCommand