Fix: View was already initialized #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in
react-native-ios-utilities
that occurs during multiple re-renders, caused by improper initialization on the native side.Fix
The line:
[[viewDelegateClass new] initWithFrame:self.frame];
was replaced with:[[viewDelegateClass alloc] initWithFrame:self.frame];
This change eliminates an unnecessary extra call to init(), which was causing conflicts during re-initialization.
Reason for Crash
The use of new implicitly calls alloc followed by init, and subsequently
initWithFrame:
is called again, leading to double initialization of the view. By explicitly using alloc withinitWithFrame:,
the redundant init call is avoided, ensuring proper initialization.Error