Skip to content

[iOS] Crash on React Native 0.77 - Context Menu View x RNIBaseView #21

@delphinebugner

Description

@delphinebugner

Hi!

Thanks for working on the lib; I'm updating my app from React Native 0.76 to React Native 0.77, and it crashes because of react-native-ios-context-menu and reat-native-ios-utilities

First opened an issue on Zeego's repo: nandorojo/zeego#141 (comment)

But it's the Context Menu View only that crashes with this stack trace:

0   CoreFoundation                	       0x1804b70e0 __exceptionPreprocess + 160
1   libobjc.A.dylib               	       0x18008ede8 objc_exception_throw + 72
2   CoreFoundation                	       0x1804b6c80 -[NSException init] + 0
3   Foundation                    	       0x180eaa40c -[NSObject(NSKeyValueCoding) valueForUndefinedKey:] + 188
4   Foundation                    	       0x180ea92f0 -[NSObject(NSKeyValueCoding) valueForKey:] + 260
5   App.debug.dylib                 0x107ca2e10 __49-[RCTComponentData createPropBlock:isShadowView:]_block_invoke_2.45 + 316 (RCTComponentData.mm:341)
6   App.debug.dylib           	       0x107ca367c __49-[RCTComponentData propBlockForKey:isShadowView:]_block_invoke_2 + 52 (RCTComponentData.mm:367)
7   App.debug.dylib           	       0x107d0a628 RCTPerformBlockWithLogFunction + 408 (RCTLog.mm:167)

Error message is "Error setting onMenuWillShow of RNIContextMenuButton"

Context Menu crashes because valueForUndefinedKey can't be found for props key reactEventHandler for a RCTView -> should it call RNIBaseView+KVC here?

See the (roughly) explaining screenshots:

image

It looks really close to the code written in this PR: #11, so @coolsoftwaretyler if you have an opinion on this, as author of the RNIBaseView+KVC change !

Disclaimer: I'm a newbie concerning ObjectiveC code 😅

Tried to build a repro but it works fine on an empty project, only fails on my app :/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions