Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I was taking a look at this package as part of #7273 in so doing made these (very tiny) tweaks.
CoordinatePoint()
, there was a fallback that was not being hit in any of my tests where it could return aVector{Float64}
instead of aNTuple{4,Float64}
. This would cost an allocation unless the compiler elides it, and could cause type instability if used improperly since the inferred return type here was a union.AbstractMaterial
was declared twice (causing warnings from the docs tools). The one I did not remove had to stay where it was because of declaration ordering.ADAM
SGD, now calledAdam
) in one of the examples.Pretty trivial stuff, but figured all that would be uncontroversial so I might as well offer to merge my tweaks.