Creating new layout crashes Gnome 48

[royborgen]

I am using GNOME 48 RC and Tiling Shell version 99 (16.3).
When I try to create a 'New Layout' in Tiling Shell, it crashes GNOME and sends me back to the login screen.

To Reproduce
Steps to reproduce the behavior:

1. Click on the Tiling Shell app icon in the GNOME panel.
2. Choose 'New Layout.'
3. Click 'Start editing.'
4. Customize your new layout, and GNOME crashes.

Information (please complete the following):

• Tiling Shell version: 99 (16.3)
• GNOME version: 48 RC

Additional context
Please see attached systemd logs.

tiling-shell-gnome-crash.log

[domferr]

Hey thank you for sharing this bug! Can you share if you got the same problem with Tiling Shell v16.2? Thank you!

[royborgen]

Hey thank you for sharing this bug! Can you share if you got the same problem with Tiling Shell v16.2? Thank you!

Unfortunately I have the same issue in 16.2 :(

[domferr]

That's great! It means the changes I did in v16.3 that are specifically to the layout editor are not breaking anything 😆
I'll have a look as soon as I get my VM with GNOME 48 working, I'll give you some updates soon!

[royborgen]

That's great! It means the changes I did in v16.3 that are specifically to the layout editor are not breaking anything 😆 I'll have a look as soon as I get my VM with GNOME 48 working, I'll give you some updates soon!

Thanks a lot! I appreciate your work! I can't live without this extension :)
At least it is still working :)

I edited my original post and added logs that make more sense.

[ledbettj]

I see the same thing, specifically when moving the mouse over the divider handle in the edit/create layout view.

Mar 24 16:29:11 thesus gnome-shell[6496]: #1   55f8186c3598 i   resource:///org/gnome/shell/ui/init.js:21 (28c77377ea60 @ 48)
Mar 24 16:29:11 thesus gnome-shell[6496]: #0   55f8186c3628 i   file:///home/john/.local/share/gnome-shell/extensions/tilingshell@ferrarodomenico.com/extension.js:4787 (185a87048a60 @ 28)
Mar 24 16:29:11 thesus gnome-shell[6496]: == Stack trace for context 0x55f8185cc340 ==
Mar 24 16:29:11 thesus gnome-shell[6496]: Bail out! libmutter:ERROR:../mutter/src/backends/meta-cursor-sprite-xcursor.c:421:load_cursor_from_theme: assertion failed: (sprite_xcursor->cursor != META_CURSO>
Mar 24 16:29:11 thesus gnome-shell[6496]: libmutter:ERROR:../mutter/src/backends/meta-cursor-sprite-xcursor.c:421:load_cursor_from_theme: assertion failed: (sprite_xcursor->cursor != META_CURSOR_INVALID)
Mar 24 16:29:11 thesus gnome-shell[6496]: **

The issue seems to be that the cursor constants have changed in Gnome 48; WEST_RESIZE and NORTH_RESIZE seem to have been renamed to W_RESIZE and N_RESIZE. I confirmed locally that changing these constants in preferredCursor resolves the crash for me :)

In looking glass:

Object.keys(Meta.Cursor)

Cheers!

[skewty]

Maintenance may be troublesome unless something like this is done / used:

export const TilingCursor = gnome.version < 48 ? {
  WEST_RESIZE: Meta.Cursor.W_RESIZE
  ... other used entries
} : {
  WEST_RESIZE: Meta.Cursor.WEST_RESIZE
  ... other used entries
}

or

export const TilingCursor = {
  WEST_RESIZE: Meta.Cursor.WEST_RESIZE ?? Meta.Cursor.W_RESIZE
  ... other used entries
}

Are there better approaches to this sort of problem?

This keeps the code cleaner and easier to read.

[Fingel]

Maintenance may be troublesome unless something like this is done / used:

export const TilingCursor = gnome.version < 48 ? {
WEST_RESIZE: Meta.Cursor.W_RESIZE
... other used entries
} : {
WEST_RESIZE: Meta.Cursor.WEST_RESIZE
... other used entries
}

or

export const TilingCursor = {
WEST_RESIZE: Meta.Cursor.WEST_RESIZE ?? Meta.Cursor.W_RESIZE
... other used entries
}

Are there better approaches to this sort of problem?

This keeps the code cleaner and easier to read.

See https://github.com/domferr/tilingshell/pull/297/files

Gotta love GNOME changing up their API each release to keep extension authors on their toes.

[FxQt]

Just for very urgent needs: if I don't hover/touch/click the divider handle, I was able to successfully define a new layout. Makes sense with the finding above, as the cursor don't trigger the resize.

[domferr]

Hey everyone, thank you so much for sharing all of this! My GNOME 48 virtual machine is completely broken and I am not able anymore to test, but your insights are awesome.

In the official guide to port extensions to GNOME 48 was not written that they changed the cursors enum... I am open to port Tiling Shell, I can understand them changing API, however they already DO NOT provide any help when the API changes and I would at least expect them to write down an exhaustive list of all the changes 🤕

By the way, apart from the critics, I am merging the pull request, thank you so much! I'll send you a build with the fix in a couple of minutes so you can install locally. I plan to publish the new release this weekend 🚀

[domferr]

Here it is! Let me know if you have any issues, enjoy!

tilingshell@ferrarodomenico.com.zip