Skip to content

Commit

Permalink
Remove support for Internet Explorer 11 (pypi#11761)
Browse files Browse the repository at this point in the history
* docs: remove language about supporting ie11

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore: remove `@stimulus/polyfills`

- Remove the import from usage.
- Remove the package and its dependencies.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore: update supported browsers

Periodic `npx browserslist@latest --update-db`

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore: remove any css overrides for ie11

Remove any specific changes commented for ie11.

Reverses: pypi#3841 pypi#3879

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
  • Loading branch information
miketheman and di committed Jul 6, 2022
1 parent 987a9ce commit dd05e26
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 52 deletions.
2 changes: 1 addition & 1 deletion docs/development/frontend.rst
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ of some pages, but the "new" version of others.
Browser Support
---------------

We aim to support all major browsers, including IE11. We also support one-back,
We aim to support all major browsers. We also support one-back,
and follow the ``defaults`` recommendation from ``browserslist``.

You can see the full list of supported browsers by running ``npx browserslist``
Expand Down
41 changes: 8 additions & 33 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@babel/preset-env": "7.18.0",
"@babel/register": "7.17.7",
"@fortawesome/fontawesome-free": "5.13.0",
"@stimulus/polyfills": "1.1.1",
"babel-loader": "8.2.5",
"clipboard": "1.7.1",
"cookie": "0.4.0",
Expand Down
1 change: 0 additions & 1 deletion warehouse/static/js/warehouse/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import "@babel/polyfill";

// Import stimulus
import "@stimulus/polyfills";
import { Application } from "stimulus";
import { definitionsFromContext } from "stimulus/webpack-helpers";

Expand Down
15 changes: 0 additions & 15 deletions warehouse/static/sass/base/_tables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,6 @@
// TABLES

table {
th,
td {
text-align: left; // Required for ie11 where it is centered by default
}

th[align="right"],
td[align="right"] {
text-align: right; // Override the above when explicitly set
}

th[align="center"],
td[align="center"] {
text-align: center; // Override the above when explicitly set
}

tbody th {
font-weight: normal;
}
Expand Down
2 changes: 1 addition & 1 deletion warehouse/static/sass/blocks/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
opacity: 0;
visibility: hidden;
display: flex;
flex-direction: column; // Required for ie11
align-items: center;
justify-content: center;
flex-grow: 1;
text-align: left;

Expand Down

0 comments on commit dd05e26

Please sign in to comment.