-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test race condition #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only possibly-contentious item is the error comparison that is known not to be compatible with TinyGo.
IMO, we should develop this as if TinyGo will gain that feature by the time Domainr and TinyGo need to ship these things together.
All changes have been made. I'm stepping away from the keyboard for 30mins and I'll merge when I'm back. |
We're seeing data race issues in CI:
https://github.com/domainr/epp2/actions/runs/8330541688/job/22795438262?pr=22
There are a few different asynchronous layers within these epp2 tests...
echoServer
is run in a goroutine and reads fromt
.echoServer
also runs a separate goroutine that writes tot
.echoServer
also runs multiple goroutines to write tot
.The changes in this PR should resolve the data race issue.
Instead of passing around the
*testing.T
I'm using channels to handle the coordination/synchronization of error messages.