Skip to content

Disable npm install scripts#3946

Merged
martincostello merged 1 commit into
masterfrom
disable-npm-install-scripts
May 12, 2026
Merged

Disable npm install scripts#3946
martincostello merged 1 commit into
masterfrom
disable-npm-install-scripts

Conversation

@martincostello
Copy link
Copy Markdown
Collaborator

  • Disable npm install scripts.
  • Force the registry to be npm.

- Disable npm install scripts.
- Force the registry to be npm.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (59b4de1) to head (492f590).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3946   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         111      111           
  Lines        3958     3958           
  Branches      801      801           
=======================================
  Hits         3762     3762           
  Misses        196      196           
Flag Coverage Δ
Linux 95.04% <ø> (ø)
Windows 95.04% <ø> (ø)
macOS 95.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello marked this pull request as ready for review May 12, 2026 10:03
Copilot AI review requested due to automatic review settings May 12, 2026 10:03
@martincostello martincostello enabled auto-merge (squash) May 12, 2026 10:03
@martincostello martincostello merged commit fd00e32 into master May 12, 2026
17 checks passed
@martincostello martincostello deleted the disable-npm-install-scripts branch May 12, 2026 10:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to harden the repo’s Node dependency installation used to build the embedded SwaggerUI/ReDoc assets by (1) disabling npm lifecycle scripts and (2) forcing installs to use the public npm registry.

Changes:

  • Add per-package npm configuration to force registry=https://registry.npmjs.org and disable install scripts.
  • Update npm lockfiles to align resolved tarball URLs with registry.npmjs.org.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Swashbuckle.AspNetCore.SwaggerUI/.npmrc‎ Adds npm config to force npm registry and disable lifecycle scripts (but filename appears to include an invisible Unicode character).
src/Swashbuckle.AspNetCore.ReDoc/.npmrc‎ Adds npm config to force npm registry and disable lifecycle scripts (but filename appears to include an invisible Unicode character).
src/Swashbuckle.AspNetCore.SwaggerUI/package-lock.json Lockfile resolved URLs point at https://registry.npmjs.org/....
src/Swashbuckle.AspNetCore.ReDoc/package-lock.json Lockfile resolved URLs point at https://registry.npmjs.org/....

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This was referenced May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants