Support .NET 9 #3007

martincostello · 2024-08-01T17:04:09Z

Add support for .NET 9 and drop support for out-of-support versions of .NET.

Changes:

Add net9.0 TFMs.
Drop TFMs for all out-of-support versions of .NET (except .NET 6) to resolve Drop support for out-of-support .NET versions #2798.
Bump version to 7.0.0.
Only audit direct NuGet dependencies.
Suppress vulnerabilities in IdentityServer4 used in sample flagged by the .NET 9 SDK.
Remove some now-redundant pre-processor directives.
Make all the middleware classes internal to resolve Consider making more types internal #2805.

codecov-commenter · 2024-08-01T17:11:41Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (6995d8a) to head (a52eda5).
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
- Coverage   91.43%   81.99%   -9.45%     
==========================================
  Files          76       76              
  Lines        3119     3121       +2     
  Branches      519      520       +1     
==========================================
- Hits         2852     2559     -293     
- Misses        267      562     +295

Flag	Coverage Δ
Linux	`81.99% <100.00%> (-9.45%)`	⬇️
Windows	`81.99% <100.00%> (-9.45%)`	⬇️
macOS	`81.99% <100.00%> (-9.45%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/Swashbuckle.AspNetCore.IntegrationTests/Swashbuckle.AspNetCore.IntegrationTests.csproj

bkoelman

It's great to see preparations being made for .NET 9. I've shared some comments based on my own experience, that may be of help.

.github/workflows/build.yml

Directory.Build.props

src/Swashbuckle.AspNetCore.Annotations/Swashbuckle.AspNetCore.Annotations.csproj

- Add `net9.0` TFMs. - Drop TFMs for all out-of-support versions of .NET. - Bump version to `7.0.0`. - Only audit direct NuGet dependencies. - Suppress vulnerabilities in IdentityServer4 used in sample. - Remove some now-redundant pre-processor directives.

Target .NET 9 versions for Microsoft.AspNetCore.OpenApi in test sites.

Bump Microsoft.OpenApi to the latest version.

* Update .NET SDK Update .NET SDK to version 9.0.100-preview.7.24407.12. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update NuGet packages Bump NuGet packages for .NET 9 preview 7. --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>

Bump Microsoft.OpenApi to 1.6.18.

Bump Microsoft.OpenApi to 1.6.20.

Update Microsoft.OpenApi to 1.6.21.

* Update .NET SDK Update .NET SDK to version 9.0.100-rc.1.24452.12. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update NuGet packages Update NuGet packages for RC1. --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>

Make all the middleware classes internal as they have no useful public-facing functionality (e.g. virtual members). Resolves #2805.

* Update .NET SDK Update .NET SDK to version 9.0.100-rc.2.24474.11. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update NuGet packages Update NuGet packages for .NET 9 RC2. --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>

Bump Microsoft.OpenApi to 1.6.22.

Update packages for ASP.NET Core 8.0.10.

Put the newest first so Visual Studio loads the latest version as the selected TFM by default.

test/WebSites/NswagClientExample/NswagClientExample.csproj

test/WebSites/OAuth2Integration/OAuth2Integration.csproj

- Remove redundant comment. - Add link to tracking issue in comment.

martincostello · 2024-10-17T07:43:06Z

@mesMess Could I get a review/approval on this PR ahead-of-time please? I'd like to be able to merge this and ship a release on 12th November once the stable 9.0.0 packages are in NuGet.org.

jgarciadelanoceda · 2024-10-17T17:44:05Z

@martincostello the dotnet6 release is going to be out of release the same day that dotnet9 comes, why not deleting also dotnet6?
Also if the nugget of STJ is greater than 8 we can delete a lot of compiled primitives that are present in #2988 have you considered it?

martincostello · 2024-10-17T18:09:13Z

It was considered (see original issue) but I decided against it to not generate a cliff on day 1 of support ending. 6 will be removed in a future release.

Keeping the package versions in line with the TFMs keeps things in configurations that the .NET team explicitly test for, makes things easier to reason about to support, and means assemblies that ship with the shared framework able to be referenced in the deployed application. Making a .NET 8 app use .NET 9 assemblies bloats the deployed application as it has to include a copy of the newer assemblies. You can see Aspire 9 does this for example for its net8.0 and net9.0 targets.

jgarciadelanoceda · 2024-10-17T18:33:59Z

Yeah I was thinking of .net standard and also framework only, because( I do not know if many are using), but it can give the users of that platforms the ability of using the new STJ attributes.
Just sifting the reference of the nugget to a recent one ( it was lower than 5).
The compile directive has to change in order to support this to net>7 or net standard.. hopefully that works

martincostello · 2024-10-17T18:43:50Z

Maybe, but sometimes libraries have some features that only light up in newer runtimes due to language features needed, or new APIs or overloads of them. Trying to run a .NET 6 app with a 9 package won't have been tested for, and won't necessarily be able to use any improvements (or worse, fall back to netstandard2.0 and then lose even 5.0 or 6.0 specific features).

Ultimately, it's not worth the complexity/burden to us in terms of support, over just using 6 with 6, 8 with 8 etc.

If people want new features, they can upgrade their apps to the version that introduces them.

mesMess · 2024-10-17T19:48:02Z

@mesMess Could I get a review/approval on this PR ahead-of-time please? I'd like to be able to merge this and ship a release on 12th November once the stable 9.0.0 packages are in NuGet.org.

Yep, I'll do that today.

mesMess

Build bump 7 -> 8 (next LTS)
Microsoft OenApi version bump
Bump to the RC for .NET 9
Moving some object to internal from public
Some of the shipped/un-shipped files are empty
Sealing some internal classes (UI)

React to aspnet/Announcements#514 for .NET 9.

Update to the stable version of .NET 9.

test/Swashbuckle.AspNetCore.IntegrationTests/Swashbuckle.AspNetCore.IntegrationTests.csproj

Bump test packages for .NET 8.

bkoelman · 2024-11-12T19:43:22Z

That's fast!

PS: Best of luck with your talk at netconf.

coderdnewbie · 2024-11-13T20:18:04Z

Thanks for supporting .Net 9.0, just made my life a lot easier.

martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version labels Aug 1, 2024

martincostello added this to the v7.0.0 milestone Aug 1, 2024

martincostello mentioned this pull request Aug 1, 2024

[Feature request]: Replace usage of IdentityServer4 in tests #3008

Open

martincostello force-pushed the dotnet-vnext branch from 8114ddd to 1f1d856 Compare August 2, 2024 07:43

martincostello force-pushed the dotnet-vnext branch 3 times, most recently from 3035e94 to 3b7a626 Compare August 18, 2024 10:05

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 2ae52bb to 59eb50f Compare August 27, 2024 09:06

martincostello mentioned this pull request Sep 11, 2024

.NET9: Microsoft.AspNetCore.OpenApi.OpenApiSchemaService should not be internal dotnet/aspnetcore#57798

Closed

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 8649844 to 8a1a816 Compare September 26, 2024 11:24

martincostello mentioned this pull request Sep 30, 2024

Drop support for out-of-support .NET versions #2798

Closed

martincostello force-pushed the dotnet-vnext branch from 8a1a816 to 97ecc3a Compare September 30, 2024 09:02

martincostello force-pushed the dotnet-vnext branch from 28c0b81 to 91b447e Compare October 9, 2024 10:36

martincostello commented Oct 9, 2024

View reviewed changes

test/Swashbuckle.AspNetCore.IntegrationTests/Swashbuckle.AspNetCore.IntegrationTests.csproj Outdated Show resolved Hide resolved

bkoelman reviewed Oct 13, 2024

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

Directory.Build.props Outdated Show resolved Hide resolved

src/Swashbuckle.AspNetCore.Annotations/Swashbuckle.AspNetCore.Annotations.csproj Outdated Show resolved Hide resolved

martincostello and others added 10 commits October 15, 2024 11:59

Support .NET 9

94dfdaa

- Add `net9.0` TFMs. - Drop TFMs for all out-of-support versions of .NET. - Bump version to `7.0.0`. - Only audit direct NuGet dependencies. - Suppress vulnerabilities in IdentityServer4 used in sample. - Remove some now-redundant pre-processor directives.

Update package references

3ffef4f

Target .NET 9 versions for Microsoft.AspNetCore.OpenApi in test sites.

Bump Microsoft.OpenApi

6dd102b

Bump Microsoft.OpenApi to the latest version.

Bump Microsoft.OpenApi

c8421c8

Bump Microsoft.OpenApi to 1.6.18.

Bump Microsoft.OpenApi

643e0fc

Bump Microsoft.OpenApi to 1.6.20.

Bump Microsoft.OpenApi

6415900

Update Microsoft.OpenApi to 1.6.21.

Make middlewares internal

68e2d88

Make all the middleware classes internal as they have no useful public-facing functionality (e.g. virtual members). Resolves #2805.

martincostello added 3 commits October 15, 2024 11:59

Bump Microsoft.OpenApi

49934ee

Bump Microsoft.OpenApi to 1.6.22.

Bump packages

dbc1c53

Update packages for ASP.NET Core 8.0.10.

Swap order of TFMs

7ba7bcf

Put the newest first so Visual Studio loads the latest version as the selected TFM by default.

martincostello force-pushed the dotnet-vnext branch from a296e67 to 7ba7bcf Compare October 15, 2024 10:59

martincostello commented Oct 17, 2024

View reviewed changes

test/WebSites/NswagClientExample/NswagClientExample.csproj Outdated Show resolved Hide resolved

test/WebSites/OAuth2Integration/OAuth2Integration.csproj Outdated Show resolved Hide resolved

Apply suggestions from code review

55ff025

- Remove redundant comment. - Add link to tracking issue in comment.

mesMess approved these changes Oct 18, 2024

View reviewed changes

Add [ActivatorUtilitiesConstructor]

7b37ca6

React to aspnet/Announcements#514 for .NET 9.

mesMess approved these changes Oct 31, 2024

View reviewed changes

martincostello mentioned this pull request Nov 8, 2024

Fix FromForm without WithOpenApi schemas #3133

Merged

Update to .NET 9 GA

df713ab

Update to the stable version of .NET 9.

martincostello commented Nov 12, 2024

View reviewed changes

test/Swashbuckle.AspNetCore.IntegrationTests/Swashbuckle.AspNetCore.IntegrationTests.csproj Outdated Show resolved Hide resolved

Bump .NET 8 packages

a52eda5

Bump test packages for .NET 8.

martincostello marked this pull request as ready for review November 12, 2024 19:35

martincostello enabled auto-merge (squash) November 12, 2024 19:35

martincostello merged commit a8eaca6 into master Nov 12, 2024
8 checks passed

martincostello deleted the dotnet-vnext branch November 12, 2024 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support .NET 9 #3007

Support .NET 9 #3007

martincostello commented Aug 1, 2024 •

edited

Loading

codecov-commenter commented Aug 1, 2024 •

edited

Loading

bkoelman left a comment

martincostello commented Oct 17, 2024

jgarciadelanoceda commented Oct 17, 2024

martincostello commented Oct 17, 2024 •

edited

Loading

jgarciadelanoceda commented Oct 17, 2024 •

edited

Loading

martincostello commented Oct 17, 2024

mesMess commented Oct 17, 2024

mesMess left a comment

bkoelman commented Nov 12, 2024

coderdnewbie commented Nov 13, 2024

Support .NET 9 #3007

Support .NET 9 #3007

Conversation

martincostello commented Aug 1, 2024 • edited Loading

codecov-commenter commented Aug 1, 2024 • edited Loading

Codecov Report

bkoelman left a comment

Choose a reason for hiding this comment

martincostello commented Oct 17, 2024

jgarciadelanoceda commented Oct 17, 2024

martincostello commented Oct 17, 2024 • edited Loading

jgarciadelanoceda commented Oct 17, 2024 • edited Loading

martincostello commented Oct 17, 2024

mesMess commented Oct 17, 2024

mesMess left a comment

Choose a reason for hiding this comment

bkoelman commented Nov 12, 2024

coderdnewbie commented Nov 13, 2024

martincostello commented Aug 1, 2024 •

edited

Loading

codecov-commenter commented Aug 1, 2024 •

edited

Loading

martincostello commented Oct 17, 2024 •

edited

Loading

jgarciadelanoceda commented Oct 17, 2024 •

edited

Loading