- Add a warning when BIMI records do not provide a mark certificate

- Ude the correct dependency (`xmltodict`, not `xml2dict`)
domainaware · Oct 26, 2024 · b9823bf · b9823bf
1 parent d9b9a33
commit b9823bf
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 Changelog
 =========
 
+5.6.2
+-----
+
+- Add a warning when BIMI records do not provide a mark certificate
+- Ude the correct dependency (`xmltodict`, not `xml2dict`)
+
 5.6.1
 -----
 

diff --git a/checkdmarc/_constants.py b/checkdmarc/_constants.py
@@ -18,7 +18,7 @@
 See the License for the specific language governing permissions and
 limitations under the License."""
 
-__version__ = "5.6.1"
+__version__ = "5.6.2"
 
 OS = platform.system()
 OS_RELEASE = platform.release()

diff --git a/checkdmarc/bimi.py b/checkdmarc/bimi.py
@@ -372,6 +372,7 @@ def parse_bimi_record(
 
     pairs = BIMI_TAG_VALUE_REGEX.findall(record)
     tags = OrderedDict()
+    certificate_provided = False
 
     for pair in pairs:
         tag = pair[0].lower().strip()
@@ -421,11 +422,16 @@ def parse_bimi_record(
             try:
                 response = session.get(tag_value)
                 response.raise_for_status()
+                certificate_provided = True
             except Exception as e:
                 warnings.append(
                     f"Unable to download Authority Evidence at "
                     f"{tag_value} - {str(e)}"
                 )
+    if not certificate_provided:
+        warnings.append(
+            "Most providers will not display a BIMI image without a mark certificate"
+        )
 
     return OrderedDict(tags=tags, warnings=warnings)
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -37,7 +37,7 @@ dependencies = [
     "pyleri>=1.3.2",
     "requests>=2.25.0",
     "timeout-decorator>=0.4.1",
-    "xml2dict>=0.2.2",
+    "xmltodict>=0.14.2",
 ]
 
 [project.scripts]

diff --git a/requirements.txt b/requirements.txt
@@ -4,7 +4,7 @@ expiringdict>=1.1.4
 pyleri>=1.3.2
 publicsuffixlist>=0.10.0
 requests>=2.25.0
-xml2dict>=0.2.2
+xml2dict>=0.14.2
 timeout-decorator>=0.5.0
 flake8>=3.8.4
 sphinx>=3.3.1