Support Varchar(MAX) #188
Merged
Support Varchar(MAX) #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Thanks for contributing this @rafimuhammad01! 🙏 Good job figuring out the various layers involved in this change.
Code looks good; I only had a few minor comments.
go/vt/sqlparser/sql.y
Outdated
Comment on lines
468
to
469
| %type <sqlVal> length_opt column_comment ignore_number_opt | ||
| %type <sqlVal> var_length_opt column_comment ignore_number_opt |
There was a problem hiding this comment.
There's some duplication here that would be good to simplify:
Suggested change
| %type <sqlVal> length_opt column_comment ignore_number_opt | |
| %type <sqlVal> var_length_opt column_comment ignore_number_opt | |
| %type <sqlVal> var_length_opt length_opt column_comment ignore_number_opt |
There was a problem hiding this comment.
I don't know if this possible in yacc since I'm new with it. Thanks for the feedback! 🍻
fulghum
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to dolthub/dolt#2261