add support for scan op #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsehn
reviewed
May 23, 2023
jsonpath.go
Outdated
| obj, err = get_scan(obj) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| default: | ||
| return nil, fmt.Errorf("expression don't support in filter") |
reltuk
approved these changes
May 23, 2023
jsonpath_test.go
Outdated
| "key": 1, | ||
| } | ||
| res, err := get_scan(obj) | ||
| fmt.Println(err, res) |
There was a problem hiding this comment.
This file seems to use both fmt.Println and t.Logf in the tests, but t.Logf is preferable, so let's use that here.
jsonpath.go
Outdated
Comment on lines
571
to
573
| for _, kv := range reflect.ValueOf(obj).MapKeys() { | ||
| res = append(res, reflect.ValueOf(obj).MapIndex(kv).Interface()) | ||
| } |
There was a problem hiding this comment.
Slightly better as:
Suggested change
| for _, kv := range reflect.ValueOf(obj).MapKeys() { | |
| res = append(res, reflect.ValueOf(obj).MapIndex(kv).Interface()) | |
| } | |
| iter := reflect.ValueOf(obj).MapRange() | |
| for iter.Next() { | |
| res = append(res, iter.Value().Interface()) | |
| } |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asterisk operator (
*), is compiled into the"scan"operation, which we are missing a case for.Fix for: dolthub/dolt#6006