Added Support for Full MySQL TRIM Syntax #605
Conversation
…o james/fix-2297-implement-string-functions
| trimType | ||
| } | ||
| // Cast to string | ||
| var pat_text string |
There was a problem hiding this comment.
Some more tests are in order, but you probably want to use Convert() of a string type rather than a simple type assertion like this
E.g. this works:
mysql> SELECT TRIM(LEADING 1 FROM '111barxxx');
+----------------------------------+
| TRIM(LEADING 1 FROM '111barxxx') |
+----------------------------------+
| barxxx |
+----------------------------------+
| return "rtrim" | ||
| case bTrimType: | ||
| return "trim" | ||
| // Cast to string type |
There was a problem hiding this comment.
mysql> SELECT TRIM(LEADING 1 FROM 111222);
+-----------------------------+
| TRIM(LEADING 1 FROM 111222) |
+-----------------------------+
| 222 |
+-----------------------------+
| // Type implements the Expression interface. | ||
| func (t *Trim) Type() sql.Type { return sql.LongText } | ||
| // Evaluate direction | ||
| dir, err := t.dir.Eval(ctx, row) |
There was a problem hiding this comment.
This one should be a static constant, no need to eval (see other PR comment)
| expression.UnaryExpression | ||
| } | ||
|
|
||
| func NewLeftTrim(str sql.Expression) sql.Expression { |
There was a problem hiding this comment.
This and NewRightTrim need to be updated in registry.go
jycor
changed the title
| Expected: []sql.Row{{"2"}}, | ||
| }, | ||
| { | ||
| Query: `SELECT TRIM(LEADING 1 FROM 11111112)`, |
There was a problem hiding this comment.
You want a few test cases with a match of the trim phrase in the middle of the word that don't get trimmed, e.g. trim(trailing "a" from "baba") == bab, trim(trailing "ab" from "baba") == baba
There was a problem hiding this comment.
Also want some tests cases where the expressions for trimming are not literals
Some where they are column values, some where they are function calls (e.g. concat("a", "b"))
| lTrimType trimType = 'l' | ||
| rTrimType trimType = 'r' | ||
| bTrimType trimType = 'b' | ||
| LEADING string = "l" |
…ithub.com/dolthub/go-mysql-server into james/fix-2297-implement-string-functions
…ithub.com/dolthub/go-mysql-server into james/fix-2297-implement-string-functions
enginetest/queries.go
Outdated
| Query: `SELECT TRIM(LEADING "ooo" FROM TRIM("oooo"))`, | ||
| Expected: []sql.Row{{"o"}}, | ||
| }, | ||
|
|
| lTrimType trimType = 'l' | ||
| rTrimType trimType = 'r' | ||
| bTrimType trimType = 'b' | ||
| LEADING string = "l" |
enginetest/queries.go
Outdated
| Query: `SELECT SUBSTRING_INDEX(mytable.s, "d", 1) AS s FROM mytable INNER JOIN othertable ON (SUBSTRING_INDEX(mytable.s, "d", 1) = SUBSTRING_INDEX(othertable.s2, "d", 1)) GROUP BY 1 HAVING s = 'secon'`, | ||
| Expected: []sql.Row{{"secon"}}, | ||
| }, | ||
|
|
2 participants
Parser recognizes keywords like: LEADING, TRAILING, and BOTH.
TRIM function can now remove prefixes.
Fixed LTRIM And RTRIM to not remove all whitespace, and just space characters.
Also added functionality for RIGHT function.
fixes: dolthub/dolt#2199