Delete From support for Empty Table #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something doesn't add up here, why is an |
|
I should've left this in WIP because I wanted to think it through again in the morning but the problem is coming from here: The test case essentially simulates a bad filter (one that has an impossible condition) on a delete query. This was the problem with this issue. We should just return an empty row iter like mysql, otherwise the delete will error out. |
andy-wm-arthur
approved these changes
Jul 21, 2021
…ql-server into vinai/exit-on-empty-table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed bug found in dolthub/dolt#1923