implicit commit on ddl statements #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Jan 21, 2025
| @@ -232,6 +232,7 @@ func (b *Builder) buildSubquery(inScope *scope, stmt ast.Statement, subQuery str | |||
| case *ast.Show: | |||
| return b.buildShow(inScope, n) | |||
| case *ast.DDL: | |||
| b.qFlags.Set(sql.QFlagDDL) | |||
There was a problem hiding this comment.
This is a good start but incomplete. There are other DDL operations that aren't captured by this node, notably ALTER TABLE
There was a problem hiding this comment.
Should add more tests for other statement types
There was a problem hiding this comment.
Included QFlagAlterTable and added tests for create index, create database, create procedure, create event, alter table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain queries ignore autocommit, and will implicitly commit the transaction.