implement last_days()
#2460
Merged
implement last_days()
#2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Apr 16, 2024
sql/expression/function/days.go
Outdated
| return time.Date(int(years), time.Month(months), int(days), 0, 0, 0, 0, time.UTC), nil | ||
| } | ||
|
|
||
| // LastDay is a function that the date but at the last day of the month. |
There was a problem hiding this comment.
Suggested change
| // LastDay is a function that the date but at the last day of the month. | |
| // LastDay is a function that returns the date at the last day of the month. |
| arg: expression.NewLiteral("0001-11-00", types.Text), | ||
| exp: time.Date(1, 11, 30, 0, 0, 0, 0, time.UTC), | ||
| }, | ||
| { |
There was a problem hiding this comment.
(minor) might be worth adding another date that has an incorrect day for the month, like 2020-02-30 or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql docs:
https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_last-day