Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Feb 16, 2024

The analyzer rule unnest_exists_subqueries was accidentally dropping NOT expressions when hoisting subqueries from WHERE EXISTS... clauses.

This should fix 8 sqllogictests.
Correctness: dolthub/dolt#7510

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor merged commit 404b39e into main Feb 18, 2024
@jycor jycor deleted the james/exists branch February 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants