Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Jan 15, 2024

This PR adds support for the EXP() function in MySQL.

MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_exp

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nothing seems too surprising here

v, _, err := types.Float64.Convert(val)
if err != nil {
// TODO: truncate
ctx.Warn(1292, "Truncated incorrect DOUBLE value: '%v'", val)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil check maybe

@jycor jycor merged commit 3a862f7 into main Jan 16, 2024
@jycor jycor deleted the james/exp branch January 16, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants