Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Jan 14, 2024

This PR adds support for ATAN() and ATAN2(), which just computes atan

MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_atan2

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is there any constructor validation or error cases we should add for the extra argument?

@jycor jycor merged commit b8cef38 into main Jan 16, 2024
@jycor jycor deleted the james/atan2 branch January 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants