prevent RangeJoinHeap plans over Filter nodes #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Dec 12, 2023
| }, | ||
| }, | ||
| { | ||
| q: "select * from vals join ranges on val between min and max where min >= 2 and max <= 5", |
There was a problem hiding this comment.
these two trigger the panic? could we get a couple more with some of the other rejected node types, like LIMIT, ORDER BY, PROJECT, DISTINCT. I think LIMIT and DISTINCT are both group properties, so maybe have to be checked separately
added 3 commits
December 12, 2023 11:17
max-hoffman
reviewed
Dec 12, 2023
| }, | ||
| }, | ||
| { | ||
| q: "select * from vals join (select * from ranges where min >= 2 and max <= 5 limit 1) ranges on val between min and max", |
There was a problem hiding this comment.
i don't think this one is valid as a rangeHeap, should block this transform
There was a problem hiding this comment.
distinct is another one that might error, because we don't materialize it into the tree until after join planning
max-hoffman
approved these changes
Dec 12, 2023
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't have proper handling of nodes that aren't
RangeHeaps in theRangeJoinIter.This PR makes it so that we don't create plans that would have these nodes.
Additionally, we error instead of panicking when we see an invalid node in this area.
fixes dolthub/dolt#7139