fix panic in math funcs #2168
Merged
fix panic in math funcs #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Nov 29, 2023
| func computeLog(ctx *sql.Context, v float64, base float64) (interface{}, error) { | ||
| if v <= 0 { | ||
| return float64(0), ErrInvalidArgumentForLogarithm.New(v) | ||
| ctx.Warn(3020, ErrInvalidArgumentForLogarithm.New(v).Error()) |
There was a problem hiding this comment.
is there a list of warning numbers somewhere?
There was a problem hiding this comment.
This is MySQLs list:
https://dev.mysql.com/doc/mysql-errors/8.0/en/server-error-reference.html
I don't think we have a list of these in dolt/gms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#7060
Additionally, fixes
POW()to not have the same panic and returns warnings instead of errors for certain inputs toLOG().