Virtual column index support #2083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o updating generated columns
…imary keys since they can't be nil)
…st like in keyed tables)
…nto zachmu/virtual
zachmu
changed the title
|
if you don't mind, a squash merge might be nice for this one |
max-hoffman
reviewed
Oct 25, 2023
max-hoffman
approved these changes
Oct 25, 2023
…rking interface deprected
…n index on table rewrite in some cases
…ten doesn't (and can't in some situations), new interface to the rescue
max-hoffman
reviewed
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements index support for virtual columns, and fixes several bugs related to generated columns for certain statements.
Changes the memory table index implementation to actually store secondary indexes separately, rather than fake it via the primary index. The indexes are stored via sorted slices for now. I'll do another pass and replace them, and primary storage, with btrees for speed now that I have this proof of concept working.
Also introduces a new interface for rebuilding a single index, rather than doing a complete table rewrite every time an index is created.