fix db qualified column names in order by #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-server into james/qualified
max-hoffman
approved these changes
Oct 5, 2023
| }, | ||
| }, | ||
| { | ||
| Name: "Multi-db Aliasing", |
There was a problem hiding this comment.
maybe test join's ON, USING condition?
| var foundCand bool | ||
| for _, c := range s.cols { | ||
| if strings.EqualFold(c.col, col) && (c.table == table || table == "") { | ||
| if strings.EqualFold(c.col, col) && (c.table == table || table == "") && (c.db == db || db == "") { |
There was a problem hiding this comment.
i wonder if there's any weird behavior with col/db non-nil, but table nil....so like select * from xy where mydb.``.x == 1
There was a problem hiding this comment.
idk what this is doing, but it's doing the same thing as mysql
tmp> select db1.t1.i from db1.t1 where db1.``.i > 0;
+---+
| i |
+---+
| 1 |
+---+
1 row in set (0.00 sec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not handle the case where database qualified column names would be in the order by clause.
This PR fixes that issue and adds a variety of tests with database qualified column names and database qualified table names.
There is still a case where joining two tables with the same name from two different databases results in an error; there's a skipped test for this, and a workaround is to alias the tables.
fixes dolthub/dolt#6773