make st_within use spatial indexes
#1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Mar 8, 2023
sql/analyzer/indexes.go
Outdated
| // Assume these are all BinaryExpression with exactly two children | ||
| children := e.Children() | ||
| if len(children) != 2 { | ||
| panic("st function is not a binary expression") |
There was a problem hiding this comment.
best to just error, the function already has an error return type
max-hoffman
reviewed
Mar 8, 2023
| }, | ||
| tests: []SpatialIndexPlanTestAssertion{ | ||
| { | ||
| q: "select p from point_tbl where st_within(p, point(0,0))", |
There was a problem hiding this comment.
Just confirming, this validates that point_tbl is indexed? If someone breaks this in the future this will error to notify?
There was a problem hiding this comment.
should we have a test for null point? null value input into filter? can the index be a primary? the is a keyless table, maybe a pk table also? query that returns data?
There was a problem hiding this comment.
Yes, evalSpatialIndexPlanTest should check that the plan produced contains both a Filter and a IndexAccess
There was a problem hiding this comment.
I can add tests for primary key table and a null point.
max-hoffman
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.