Skip to content

small fix for information_schema.parameters table #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023
Merged

small fix for information_schema.parameters table #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9144f60
small fix
jennifersp Jan 26, 2023
7bb54da
Merge branch 'main' into jennifer/small-fix
jennifersp Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/information_schema/information_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ var parametersSchema = Schema{
{Name: "CHARACTER_SET_NAME", Type: types.MustCreateStringWithDefaults(sqltypes.VarChar, 64), Default: nil, Nullable: true, Source: ParametersTableName},
{Name: "COLLATION_NAME", Type: types.MustCreateStringWithDefaults(sqltypes.VarChar, 64), Default: nil, Nullable: true, Source: ParametersTableName},
{Name: "DTD_IDENTIFIER", Type: types.MediumText, Default: nil, Nullable: false, Source: ParametersTableName},
{Name: "RESOURCE_GROUP_TYPE", Type: types.MustCreateEnumType([]string{"FUNCTION", "PROCEDURE"}, Collation_Default), Default: nil, Nullable: false, Source: ParametersTableName},
{Name: "ROUTINE_TYPE", Type: types.MustCreateEnumType([]string{"FUNCTION", "PROCEDURE"}, Collation_Default), Default: nil, Nullable: false, Source: ParametersTableName},
}

var partitionsSchema = Schema{
Expand Down
4 changes: 2 additions & 2 deletions sql/information_schema/routines_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,12 @@ func parametersRowIter(ctx *Context, c Catalog, p map[string][]*plan.Procedure)
charName, // character_set_name
collName, // collation_name
dtdId, // dtd_identifier
"PROCEDURE", // resource_group_type
"PROCEDURE", // routine_type
})
}
}
}
// TODO: need to add FUNCTIONS resource_group_type
// TODO: need to add FUNCTIONS routine_type

return RowsToRowIter(rows...), nil
}
Expand Down