Skip to content

fix multiple column partition #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

fix multiple column partition #1556

merged 3 commits into from
Jan 25, 2023

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Jan 25, 2023

@jycor jycor requested a review from max-hoffman January 25, 2023 08:54
max-hoffman
max-hoffman approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simple fix

@jycor jycor merged commit 6585718 into main Jan 25, 2023
@Hydrocharged Hydrocharged deleted the james/partition branch March 29, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@max-hoffman max-hoffman max-hoffman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jycor @max-hoffman