Add tests for year type behavior #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druvv
force-pushed
the
dhruv/fix-year-type
branch
from
2b94a55 to
253d41e
Compare
druvv
force-pushed
the
dhruv/fix-year-type
branch
from
253d41e to
bf9b640
Compare
max-hoffman
approved these changes
Nov 10, 2022
| }, | ||
| // 0 is interpreted as 0000 | ||
| { | ||
| Query: "INSERT INTO t VALUES (21, 0)", |
There was a problem hiding this comment.
what happens if you INSERT INTO t VALUES (22, '0')? Maybe not relevant for this specific PR, but seems like lots of potential edge cases of weird strings people could pass as years.
There was a problem hiding this comment.
It counts as the year 2000. See case 19, and 20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for dolthub/dolt#4742