Skip to content

No new context for every json SQL convert #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2022
Merged

No new context for every json SQL convert #1270

merged 1 commit into from
Sep 18, 2022

Conversation

@max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Sep 17, 2022 •
edited
Loading

perf here: dolthub/dolt#4364

@max-hoffman max-hoffman mentioned this pull request Sep 17, 2022
Merged
andy-wm-arthur
andy-wm-arthur approved these changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@max-hoffman max-hoffman merged commit 7373a7b into main Sep 18, 2022
@max-hoffman max-hoffman deleted the max/json-read-perf branch September 18, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andy-wm-arthur andy-wm-arthur andy-wm-arthur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@max-hoffman @andy-wm-arthur