Skip to content

Conversation

@jennifersp
Copy link
Contributor

STR_TO_DATE() returns result type depending on Date given in the query. If only date parts like year, month and/or day was defined in Date argument, then the result is only Date type without time parts. If Date defined is date with time, then Datetime type is returned.
Currently, STR_TO_DATE allows zero-date.

@fulghum fulghum self-requested a review August 23, 2022 21:59
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look very clean. Just a couple comments to discuss the interface/types a little bit more.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work simplifying and finding a way to avoid those two new types!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants