Bug fixes for AlterPK and column defaults #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umn defaults – triggered a bug where AlterDefaultSet was resolving columns on the wrong schema.
…n a subquery as the TargetSchema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operations that modify a table's schema were not consistently resolving column default values:
AlterPKwas missed in resolve column default switch cases, and also wasn't considering its expressions when checking for resolution.AlterDefaultSetwas resolving the wrong schema (its output schema,OkResultSchema, instead of the target schema).While I was in there, I cleaned up the code to more consistently use the
sql.TargetSchemainterface and combined some copy/pasted switch cases.Updated existing tests to use column default values and verified they caught both of these failures. Have already run Dolt engine tests and verified they pass correctly.
Fixes: dolthub/dolt#3788