Skip to content

Conversation

@max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Jul 5, 2022

dolt bump here: dolthub/dolt#3757

This expands some Convert methods into smaller helper functions that can be used more precisely:

  • avoid interface conversions
  • sidestep bound checks that don't apply on the read path unless we are explicitly running a Cast

These are a bit rough and ready, the interfaces and semantic check organization could be formalized, but gives 15% boost on table scan.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit 11ac238 into main Jul 6, 2022
@max-hoffman max-hoffman deleted the max/type-convert-simplifications branch July 6, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants