Skip to content

[auto-bump] [no-release-notes] Dolt dependency - #3587

Open
coffeegoddd wants to merge 1 commit into
mainfrom
auto-bump-dolt-eaa9030a
Open

coffeegoddd wants to merge 1 commit into
mainfrom
auto-bump-dolt-eaa9030a

Conversation

@coffeegoddd

Copy link
Copy Markdown
Contributor

☕ An Automated Dependency Version Bump PR 👑

Initial Changes

The changes contained in this PR were produced by `go get`ing the dependency.

```bash
go get github.com/dolthub/[dependency]/go@[commit]
```

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: validated dependency-only update.

@github-actions
github-actions Bot enabled auto-merge (squash) October 13, 2026 07:05
@github-actions

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 20955 20956
Failures 21135 21134
Partial Successes1 5405 5405
Main PR
Successful 49.7862% 49.7885%
Failures 50.2138% 50.2115%

${\color{lightgreen}Progressions (1)}$

rangefuncs

QUERY: select * from insert_tt2('baz','quux');

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@itoqa

itoqa Bot commented Oct 13, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 8d1ad08: 7 test cases ran, 1 failed ❌, 6 passed ✅.

Summary

Coverage spans backend data-management behavior, including branch and merge workflows, commit history, concurrent updates, rollback recovery, and preservation of committed records, along with dependency integrity and repository build validation. It focuses on happy paths and failure-recovery scenarios rather than user-interface behavior.

Merge with caution — the application builds and the exercised data workflows remain healthy, but the dependency update leaves the full test suite unable to compile because a required test harness capability is missing. This is a medium-risk merge blocker for repository verification, though it does not indicate a direct customer-facing runtime failure.

Tests run by Ito

View full run

Result Severity Type Description
❌ Medium severity Rev The full Go test suite stops before running testing/go/enginetest because DoltgresHarness no longer satisfies the interfaces supplied by the updated dependencies.
✅ — General After an invalid branch operation, the committed row stayed available. The corrected retry merged successfully, and both rows and their history remained readable.
✅ — General After one concurrent commit failed, rollback left the same session usable. The follow-up row and the surviving original row were both committed and readable.
✅ — Dolt The apparent missing row was caused by the setup using CALL for a command that must be run with SELECT. The corrected workflow completed the branch merge and kept both rows and the commit history readable.
✅ — Rev The updated Go dependencies resolve to the versions recorded in the repository, and their checksums verify successfully.
✅ — Transactions One conflicting commit failed with the expected serialization error. The winning table value and commit history stayed readable afterward.
✅ — Transactions After a transaction statement failed and was rolled back, the same connection returned the committed row and Dolt history.

Tip

Reply with @itoqa to send us feedback on this test run.

Comment thread go.mod
github.com/cockroachdb/apd/v3 v3.2.3
github.com/cockroachdb/errors v1.7.5
github.com/dolthub/dolt/go v0.40.5-0.20261013010211-55970d4e13a0
github.com/dolthub/dolt/go v0.40.5-0.20261013070258-eaa9030af908

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View All Evidence

Medium severity Go tests fail after dependency update

What failed: The full Go test suite stops before running testing/go/enginetest because DoltgresHarness no longer satisfies the interfaces supplied by the updated dependencies.

Impact · Steps · Stub / mock · Analysis · Why this is likely a bug
  • Severity: Medium Medium severity
  • Impact: Developers cannot verify the repository after the dependency update because the engine-test package no longer satisfies the required interfaces. The application build still succeeds, and no customer data or live user workflow is affected.
  • Steps to Reproduce:
    1. Use the repository with the dependency versions in go.mod.
    2. Run go build ./... from the repository root and confirm it succeeds.
    3. Run go test ./... from the repository root.
    4. Observe compilation errors in testing/go/enginetest stating that DoltgresHarness is missing SupportsValueRow.
  • Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
  • Code Analysis: The PR diff updates github.com/dolthub/dolt/go from v0.40.5-0.20261013010211-55970d4e13a0 to v0.40.5-0.20261013070258-eaa9030af908 and github.com/dolthub/go-mysql-server from v0.20.1-0.20261010002103-d67b540b0e5e to v0.20.1-0.20261013010327-d5acf30e8519 in go.mod, with matching go.sum entries. In testing/go/enginetest/doltgres_harness_test.go, lines 65-68 assign *DoltgresHarness to the DoltEnginetestHarness, SkippingHarness, ResultEvaluationHarness, and DialectHarness interfaces. The compiler reports for each relevant interface that SupportsValueRow is missing. The harness defines capability methods such as SupportsNativeIndexCreation, SupportsForeignKeys, and SupportsKeylessTables at lines 334-344, but no SupportsValueRow method exists anywhere in this type. Because go build ./... succeeds while package compilation during go test ./... fails, this is a test-package interface incompatibility rather than a general production build failure. Implementing the newly required method on DoltgresHarness is a targeted repair; alternatively, reverting or pinning the two dependency updates would avoid the new interface requirement but would not address compatibility with the intended versions.
  • Why this is likely a bug: A dependency-only PR is expected to leave the repository buildable and testable, and baseline correctness requires that ordinary package tests do not fail at compilation. The failure is deterministic and localized: the updated external interfaces demand SupportsValueRow, while the repository's harness lacks it. It blocks the entire engine-test package and therefore prevents the stated full-suite check. The PR's changed module versions are the direct trigger, not a runner mock or setup problem. The practical fix is limited to adding the missing capability method with the correct behavior for Doltgres, or reverting the specific incompatible version bump until that method is added.
Relevant code

go.mod:11-14

github.com/dolthub/dolt/go v0.40.5-0.20261013070258-eaa9030af908
github.com/dolthub/go-mysql-server v0.20.1-0.20261013010327-d5acf30e8519

testing/go/enginetest/doltgres_harness_test.go:54-68

type DoltgresHarness struct {
	t *testing.T
	// ... harness state ...
}

var _ denginetest.DoltEnginetestHarness = &DoltgresHarness{}
var _ enginetest.SkippingHarness = &DoltgresHarness{}
var _ enginetest.ResultEvaluationHarness = &DoltgresHarness{}
var _ enginetest.DialectHarness = &DoltgresHarness{}

testing/go/enginetest/doltgres_harness_test.go:334-344

func (d *DoltgresHarness) SupportsNativeIndexCreation() bool {
	return true
}

func (d *DoltgresHarness) SupportsForeignKeys() bool {
	return true
}

func (d *DoltgresHarness) SupportsKeylessTables() bool {
	return true
}
Evidence Package
Copy prompt for an agent
Ito QA identified the following failure during automated PR testing. Please investigate and propose a fix.

**Medium severity — Go tests fail after dependency update**

**What failed:** The full Go test suite stops before running testing/go/enginetest because DoltgresHarness no longer satisfies the interfaces supplied by the updated dependencies.

- **Impact:** Developers cannot verify the repository after the dependency update because the engine-test package no longer satisfies the required interfaces. The application build still succeeds, and no customer data or live user workflow is affected.
- **Steps to reproduce:**
  1. Use the repository with the dependency versions in go.mod.
  2. Run `go build ./...` from the repository root and confirm it succeeds.
  3. Run `go test ./...` from the repository root.
  4. Observe compilation errors in testing/go/enginetest stating that DoltgresHarness is missing SupportsValueRow.
- **Stub / mock content:** No stubs, mocks, or bypasses were applied for this test in the recorded run.
- **Code analysis:** The PR diff updates github.com/dolthub/dolt/go from v0.40.5-0.20261013010211-55970d4e13a0 to v0.40.5-0.20261013070258-eaa9030af908 and github.com/dolthub/go-mysql-server from v0.20.1-0.20261010002103-d67b540b0e5e to v0.20.1-0.20261013010327-d5acf30e8519 in go.mod, with matching go.sum entries. In testing/go/enginetest/doltgres_harness_test.go, lines 65-68 assign *DoltgresHarness to the DoltEnginetestHarness, SkippingHarness, ResultEvaluationHarness, and DialectHarness interfaces. The compiler reports for each relevant interface that SupportsValueRow is missing. The harness defines capability methods such as SupportsNativeIndexCreation, SupportsForeignKeys, and SupportsKeylessTables at lines 334-344, but no SupportsValueRow method exists anywhere in this type. Because go build ./... succeeds while package compilation during go test ./... fails, this is a test-package interface incompatibility rather than a general production build failure. Implementing the newly required method on DoltgresHarness is a targeted repair; alternatively, reverting or pinning the two dependency updates would avoid the new interface requirement but would not address compatibility with the intended versions.
- **Why this is likely a bug:** A dependency-only PR is expected to leave the repository buildable and testable, and baseline correctness requires that ordinary package tests do not fail at compilation. The failure is deterministic and localized: the updated external interfaces demand SupportsValueRow, while the repository's harness lacks it. It blocks the entire engine-test package and therefore prevents the stated full-suite check. The PR's changed module versions are the direct trigger, not a runner mock or setup problem. The practical fix is limited to adding the missing capability method with the correct behavior for Doltgres, or reverting the specific incompatible version bump until that method is added.

**Relevant code:**

`go.mod:11-14`

~~~go
github.com/dolthub/dolt/go v0.40.5-0.20261013070258-eaa9030af908
github.com/dolthub/go-mysql-server v0.20.1-0.20261013010327-d5acf30e8519
~~~

`testing/go/enginetest/doltgres_harness_test.go:54-68`

~~~go
type DoltgresHarness struct {
	t *testing.T
	// ... harness state ...
}

var _ denginetest.DoltEnginetestHarness = &DoltgresHarness{}
var _ enginetest.SkippingHarness = &DoltgresHarness{}
var _ enginetest.ResultEvaluationHarness = &DoltgresHarness{}
var _ enginetest.DialectHarness = &DoltgresHarness{}
~~~

`testing/go/enginetest/doltgres_harness_test.go:334-344`

~~~go
func (d *DoltgresHarness) SupportsNativeIndexCreation() bool {
	return true
}

func (d *DoltgresHarness) SupportsForeignKeys() bool {
	return true
}

func (d *DoltgresHarness) SupportsKeylessTables() bool {
	return true
}
~~~

@coffeegoddd

Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

read_tests from_latency to_latency percent_change
covering_index_scan_postgres 2.48 2.48 0.0
groupby_scan_postgres 82.96 81.48 -1.78
index_join_postgres 2.39 2.35 -1.67
index_join_scan_postgres 1.67 1.67 0.0
index_scan_postgres 475.79 475.79 0.0
oltp_point_select 0.39 0.4 2.56
oltp_read_only 6.67 6.91 3.6
select_random_points 0.74 0.74 0.0
select_random_ranges 1.08 1.1 1.85
table_scan_postgres 467.3 475.79 1.82
types_table_scan_postgres 1191.92 1191.92 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert_postgres 4.57 4.57 0.0
oltp_insert 2.18 2.26 3.67
oltp_read_write 12.75 12.98 1.8
oltp_update_index 2.48 2.48 0.0
oltp_update_non_index 2.18 2.18 0.0
oltp_write_only 5.88 5.88 0.0
types_delete_insert_postgres 5.0 5.0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant