Skip to content

Conversation

@jennifersp jennifersp requested a review from Hydrocharged April 12, 2024 22:42
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing we need to add are tests that make use of some Postgres-specific syntax. One example is CREATE VIEW v AS SELECT pk::INT2 FROM t1 ORDER BY pk;. Just a few different ones, as it looks like all of the defined views are fully valid MySQL statements, so we need to guarantee that it succeeds for invalid MySQL statements that are valid PostgreSQL statements.

@jennifersp jennifersp requested a review from Hydrocharged May 6, 2024 23:00
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just have a big question regarding the usage of the vitess parser instead of our Postgres parser.

@jennifersp jennifersp merged commit 8639d45 into main May 9, 2024
@jennifersp jennifersp deleted the jennifer/create-view branch May 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants