Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Root Object Rework #1265

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Root Object Rework #1265

wants to merge 1 commit into from

Conversation

Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Mar 10, 2025

Missing:

  • Interface that each collection inherits from that the RootValue interacts with
  • Move from types.Map to an AddressMap
  • Port existing merge logic to use individual root objects instead
  • Benchmark speed comparing inline vs ref'ed
  • Far more extensive testing (apparently some Dolt table_functions are untested, even in Dolt)
  • Documentation

Copy link
Contributor

Main PR
covering_index_scan_postgres 391.77/s ${\color{red}DNF}$
index_join_postgres 155.03/s ${\color{red}DNF}$
index_join_scan_postgres 187.51/s ${\color{red}DNF}$
index_scan_postgres 12.40/s ${\color{red}DNF}$
oltp_point_select 2804.20/s ${\color{red}DNF}$
oltp_read_only 1871.45/s ${\color{red}DNF}$
select_random_points 111.34/s ${\color{red}DNF}$
select_random_ranges 137.91/s ${\color{red}DNF}$
table_scan_postgres 10.32/s ${\color{red}DNF}$
types_table_scan_postgres 5.44/s ${\color{red}DNF}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant