Skip to content

Conversation

@Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Feb 8, 2024

This makes use of an addition to Vitess and GMS that allows for name resolution to occur for injected expressions. The new ARRAY[...] smoke test demonstrates this.

Related PRs:

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this will play nicely with name resolution. The other big issue will be type coercion, but that's separable and already a preexisting problem in GMS

@Hydrocharged Hydrocharged force-pushed the daylon/array-columns branch 3 times, most recently from ae8efb9 to 90d06cb Compare February 9, 2024 13:43
@Hydrocharged Hydrocharged merged commit f6caf50 into main Feb 9, 2024
@Hydrocharged Hydrocharged deleted the daylon/array-columns branch February 9, 2024 13:58
@Hydrocharged Hydrocharged restored the daylon/array-columns branch February 9, 2024 13:58
@Hydrocharged Hydrocharged deleted the daylon/array-columns branch February 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants