Skip to content

go/store/nbs: Add info level logging for a store conjoin. #9066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Apr 1, 2025

No description provided.

@reltuk
Copy link
Contributor Author

reltuk commented Apr 1, 2025

Operationally, conjoins can be expensive. With auto GC, it's more likely that we see these in old gen going forward.

We are working on making conjoins less impactful on a server's resource utilization and working on making them less async, so their lock overhead is much lower, but operationally it is still useful to log when they are occuring.

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
88245a5 ok 5937457
version total_tests
88245a5 5937457
correctness_percentage
100.0

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit 5fdf62d into main Apr 2, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants