Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] go: store/nbs: Unify logic from UpdateManifest and UpdateManifestWithAppendix #8813

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[no-release-notes] go: store/nbs: Unify logic from UpdateManifest and UpdateManifestWithAppendix #8813

merged 2 commits into from
Feb 5, 2025
+49 −97

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 4, 2025

No description provided.

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
13b81b9 ok 5937457
version total_tests
13b81b9 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
928ae32 ok 5937457
version total_tests
928ae32 5937457
correctness_percentage
100.0

coffeegoddd
coffeegoddd approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but if tests are passing i'm probably misreading

go/store/nbs/store.go Show resolved Hide resolved
@reltuk reltuk merged commit 973ca47 into main Feb 5, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeegoddd coffeegoddd coffeegoddd approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @coffeegoddd