Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy loading #8703

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
8b4d25b
fix more bugs
max-hoffman Nov 27, 2024
ba4b835
fix test errors
max-hoffman Nov 27, 2024
56503a0
test skip encoding
max-hoffman Nov 28, 2024
a79ecd2
refactor more iters
max-hoffman Dec 2, 2024
21f8c7f
more skip encoding
max-hoffman Dec 2, 2024
78ce3b0
filter support
max-hoffman Dec 2, 2024
e1a9bf5
fix some errors
max-hoffman Dec 2, 2024
f3d1c37
simple queries pass
max-hoffman Dec 2, 2024
42450f5
fix dml
max-hoffman Dec 3, 2024
709fdcb
merge with main
Dec 26, 2024
7ac46d5
finish using untyped sql row
Dec 26, 2024
9a6088a
bump
Dec 26, 2024
88d3700
bump
Dec 26, 2024
5bb1ae4
[skip actions] [ga-update-correctness] SQL Correctness updated to 99.…
coffeegoddd Dec 27, 2024
606f668
fixing tests
Dec 27, 2024
f95d0d6
fixes
Dec 27, 2024
5dd4448
bump
Dec 27, 2024
cb756a1
Merge branch 'james/lazy' of https://github.com/dolthub/dolt into jam…
Dec 27, 2024
32e0a10
conflicts
Dec 27, 2024
7050d11
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
jycor Dec 27, 2024
8fc99ed
[skip actions] [ga-update-correctness] SQL Correctness updated to 100
coffeegoddd Dec 28, 2024
1a4e338
test
Dec 31, 2024
e938997
merge with main
Dec 31, 2024
422bdb3
test bump
Dec 31, 2024
da955f5
fix integration tests
Jan 2, 2025
38ef12a
fix another test
Jan 2, 2025
8729493
another test
Jan 2, 2025
75e7159
better fix
Jan 2, 2025
e161a3e
more
Jan 2, 2025
4805462
fix more
Jan 2, 2025
97260c1
use index schema instead
Jan 3, 2025
3eb25b3
fix panic
Jan 3, 2025
6cd53ca
bats tests fix
Jan 3, 2025
d7c1be3
another test fixed
Jan 4, 2025
52c3f20
fix
Jan 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dml
  • Loading branch information
max-hoffman committed Dec 3, 2024
commit 42450f50a1201511d5d82ee0f8646aeafb013fb2
3 changes: 2 additions & 1 deletion go/libraries/doltcore/sqle/index/prolly_row.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ func (r *ProllyRow) SetValue(i int, v interface{}) {
}
r.mat[i] = v
r.dirty.Add(i + 1)
r.decoded.Add(i + 1)
}

func (r *ProllyRow) SetBytes(i int, v []byte) {
Expand All @@ -114,7 +115,7 @@ func (r *ProllyRow) GetType(i int) {

func (r *ProllyRow) Values() []interface{} {
for i := range r.ords {
if !r.decoded.Contains(i + 1) {
if !r.decoded.Contains(i+1) && !r.dirty.Contains(i+1) {
r.decode(context.Background(), i)
}
}
Expand Down
Loading